X-Git-Url: http://git.datanom.net/omvzfs.git/blobdiff_plain/946a8c30ebe271713f4d16830546bc37e64ef301..670691f3b555344a849ad9911814a78949c1b31b:/src/Snapshot.php

diff --git a/src/Snapshot.php b/src/Snapshot.php
index 54411e2..23231fe 100644
--- a/src/Snapshot.php
+++ b/src/Snapshot.php
@@ -41,7 +41,7 @@ class OMVModuleZFSSnapshot {
 	public function __construct($name) {
 		$this->name = $name;
 		$qname = preg_quote($name, '/');
-		$cmd = "zfs list -H -t snapshot";
+		$cmd = "zfs list -H -t snapshot 2>&1";
 		$this->exec($cmd, $out, $res);
 		foreach ($out as $line) {
 			if (preg_match('/^' . $qname . '\t.*$/', $line)) {
@@ -62,24 +62,55 @@ class OMVModuleZFSSnapshot {
 	}
 
 	/**
-	 * XXX
-	 *
-	 * @return list<Feature> XXX
+	 * Get a single property value associated with the Snapshot
+	 * 
+	 * @param string $property Name of the property to fetch
+	 * @return array The returned array with the property. The property is an associative array with
+	 * two elements, <value> and <source>.
 	 * @access public
 	 */
-	public function getFeatures() {
-		trigger_error('Not Implemented!', E_USER_WARNING);
+	public function getProperty($property) {
+		return $this->properties["$property"];
 	}
 
 	/**
-	 * XXX
-	 *
-	 * @param   $list<Feature> XXX
-	 * @return void XXX
+	 * Get an associative array of all properties associated with the Snapshot
+	 * 
+	 * @return array $properties Each entry is an associative array with two elements
+	 * <value> and <source>
+	 * @access public
+	 */
+	public function getProperties() {
+		return $this->properties;
+	}
+
+	/**
+	 * Sets a number of Snapshot properties. If a property is already set it will be updated with the new value.
+	 * 
+	 * @param  array $properties An associative array with properties to set
+	 * @return void
 	 * @access public
 	 */
-	public function setFeatures($list) {
-		trigger_error('Not Implemented!', E_USER_WARNING);
+	public function setProperties($properties) {
+		foreach ($properties as $newpropertyk => $newpropertyv) {
+			$cmd = "zfs set " . $newpropertyk . "=" . $newpropertyv . " " . $this->name . " 2>&1";
+			$this->exec($cmd,$out,$res);
+			$this->updateProperty($newpropertyk);
+		}
+	}
+
+	/**
+	 * Get single Snapshot property from commandline and update object property attribute
+	 * 
+	 * @param string $property Name of the property to update
+	 * @return void
+	 * @access private
+	 */
+	private function updateProperty($property) {
+		$cmd = "zfs get -H " . $property . " " . $this->name . " 2>&1";
+		$this->exec($cmd,$out,$res);
+		$tmpary = preg_split('/\t+/', $out[0]);
+		$this->properties["$tmpary[1]"] = array("value" => $tmpary[2], "source" => $tmpary[3]);
 	}
 
 	/**
@@ -89,7 +120,7 @@ class OMVModuleZFSSnapshot {
 	 * @access private
 	 */
 	private function updateAllProperties() {
-		$cmd = "zfs get -H all " . $this->name;
+		$cmd = "zfs get -H all " . $this->name . " 2>&1";
 		$this->exec($cmd,$out,$res);
 		unset($this->properties);
 		foreach ($out as $line) {
@@ -98,6 +129,20 @@ class OMVModuleZFSSnapshot {
 		}
 	}
 
+	/**
+	 * Craete a Snapshot on commandline. Optionally provide a number of properties to set.
+	 * 
+	 * @param array $properties Properties to set when creating the dataset.
+	 * @return void
+	 * @access public
+	 */
+	public function create(array $properties = null) {
+		$cmd = "zfs snapshot " . $this->name . " 2>&1";
+		$this->exec($cmd,$out,$res);
+		$this->updateAllProperties();
+		$this->setProperties($properties);
+	}
+
 	/**
 	 * Helper function to execute a command and throw an exception on error
 	 * (requires stderr redirected to stdout for proper exception message).