X-Git-Url: http://git.datanom.net/omvzfs.git/blobdiff_plain/cc6e6edbf80008ea35979a3470fd8ed9567274b3..946a8c30ebe271713f4d16830546bc37e64ef301:/src/Zvol.php

diff --git a/src/Zvol.php b/src/Zvol.php
index 82569d4..9be6f5e 100644
--- a/src/Zvol.php
+++ b/src/Zvol.php
@@ -23,7 +23,7 @@ class OMVModuleZFSZvol {
 	/**
 	 * Size of Zvol
 	 *
-	 * @var int $size
+	 * @var string $size
 	 * @access private
 	 */
 	private $size;
@@ -95,24 +95,28 @@ class OMVModuleZFSZvol {
 	}
 
 	/**
-	 * XXX
+	 * Get the total size of the Zvol
 	 *
-	 * @return int XXX
+	 * @return string $size
 	 * @access public
 	 */
 	public function getSize() {
-		trigger_error('Not Implemented!', E_USER_WARNING);
+		return $this->size;
 	}
 
 	/**
-	 * XXX
-	 *
-	 * @param   $list<Feature> XXX
-	 * @return void XXX
+	 * Sets a number of Zvol properties. If a property is already set it will be updated with the new value.
+	 * 
+	 * @param  array $properties An associative array with properties to set
+	 * @return void
 	 * @access public
 	 */
 	public function setProperties($properties) {
-		trigger_error('Not Implemented!', E_USER_WARNING);
+		foreach ($properties as $newpropertyk => $newpropertyv) {
+			$cmd = "zfs set " . $newpropertyk . "=" . $newpropertyv . " " . $this->name;
+			$this->exec($cmd,$out,$res);
+			$this->updateProperty($newpropertyk);
+		}
 	}
 
 	/**
@@ -131,17 +135,32 @@ class OMVModuleZFSZvol {
 		}
 	}
 
+	/**
+	 * Get single Datset property from commandline and update object property attribute
+	 * 
+	 * @param string $property Name of the property to update
+	 * @return void
+	 * @access private
+	 */
+	private function updateProperty($property) {
+		$cmd = "zfs get -H " . $property . " " . $this->name;
+		$this->exec($cmd,$out,$res);
+		$tmpary = preg_split('/\t+/', $out[0]);
+		$this->properties["$tmpary[1]"] = array("value" => $tmpary[2], "source" => $tmpary[3]);
+	}
+
 	/**
 	 * Create a Zvol on commandline. Optionally provide a number of properties to set.
 	 * 
 	 * @param string $size Size of the Zvol that should be created
-	 * @param array $properties Properties to set when creating the dataset.
+	 * @param array $properties Properties to set when creatiing the dataset.
+	 * @param boolean $sparse Defines if a sparse volume should be created.
 	 * @return void
 	 * @access public
 	 */
-	public function create($size, array $properties = null, bool $sparse = null) {
+	public function create($size, array $properties = null, $sparse = null) {
 		$cmd = "zfs create -p ";
-		if (isset($sparse) && $sparse == true) {
+		if ((isset($sparse)) && ($sparse == true)) {
 			$cmd .= "-s ";
 		}	
 		$cmd .= "-V " . $size . " " . $this->name . " 2>&1";
@@ -151,6 +170,44 @@ class OMVModuleZFSZvol {
 		$this->size = $this->properties["volsize"]["value"];
 	}
 
+	/**
+	 * Destroy the Zvol.
+	 * 
+	 * @return void
+	 * @access public
+	 */
+	public function destroy() {
+		$cmd = "zfs destroy " . $this->name;
+		$this->exec($cmd,$out,$res);
+	}
+
+	/**
+	 * Renames a Zvol
+	 * 
+	 * @param string $newname New name of the Dataset
+	 * @return void
+	 * @access public
+	 */
+	public function rename($newname) {
+		$cmd = "zfs rename -p " . $this->name . " " . $newname . " 2>&1";
+		$this->exec($cmd,$out,$res);
+		$this->name = $newname;
+	}
+
+	/**
+	 * Clears a previously set proporty and specifies that it should be
+	 * inherited from it's parent.
+	 * 
+	 * @param string $property Name of the property to inherit.
+	 * @return void
+	 * @access public
+	 */
+	public function inherit($property) {
+		$cmd = "zfs inherit " . $property . " " . $this->name . " 2>&1";
+		$this->exec($cmd,$out,$res);
+		$this->updateProperty($property);
+	}
+
 	/**
 	 * Helper function to execute a command and throw an exception on error
 	 * (requires stderr redirected to stdout for proper exception message).