X-Git-Url: http://git.datanom.net/omvzfs.git/blobdiff_plain/e419cf47cc59a0f8ea6b62a66138ea4336046dcb..97e4887b3864cc11f131c51eb337e7bb4c025e27:/src/Dataset.php

diff --git a/src/Dataset.php b/src/Dataset.php
index 9abdb82..65cca31 100644
--- a/src/Dataset.php
+++ b/src/Dataset.php
@@ -68,11 +68,13 @@ class OMVModuleZFSDataset {
 			$ds_exists = false;
 		}
 		if ($ds_exists) {
-			$cmd = "zfs list -r -o name -H -t snapshot " . $name . " 2>&1";
+			$cmd = "zfs list -r -d 1 -o name -H -t snapshot " . $name . " 2>&1";
 			$this->exec($cmd, $out2, $res2);
 			foreach ($out2 as $line2) {
-				$this->snapshots[$line2] = new OMVModuleZFSSnapshot($line2);
+					$this->snapshots[$line2] = new OMVModuleZFSSnapshot($line2);
 			}
+		} else {
+			$this->create();
 		}
 	}
 
@@ -103,7 +105,11 @@ class OMVModuleZFSDataset {
 	 * @access public
 	 */
 	public function getSnapshots() {
-		return $this->snapshots;
+		if (isset($this->snapshots)) {
+			return $this->snapshots;
+		} else {
+			return array();
+		}
 	}
 
 	/**
@@ -175,17 +181,15 @@ class OMVModuleZFSDataset {
 	}
 
 	/**
-	 * Craete a Dataset on commandline. Optionally provide a number of properties to set.
+	 * Craete a Dataset on commandline.
 	 *
-	 * @param array $properties Properties to set when creating the dataset.
 	 * @return void
-	 * @access public
+	 * @access private
 	 */
-	public function create(array $properties = null) {
+	private function create() {
 		$cmd = "zfs create -p " . $this->name . " 2>&1";
 		$this->exec($cmd,$out,$res);
 		$this->updateAllProperties();
-		$this->setProperties($properties);
 		$this->mountPoint = $this->properties["mountpoint"]["value"];
 	}
 
@@ -289,6 +293,49 @@ class OMVModuleZFSDataset {
 		unset($this->snapshots[$snap_name]);
 	}
 
+	/**
+	* Check if the Dataset is a clone or not.
+	*
+	* @return bool
+	* @access public
+	*/
+	public function isClone() {
+		$origin = $this->getProperty("origin");
+		if (strlen($origin["value"]) > 0) {
+			return true;
+		} else {
+			return false;
+		}
+	}
+
+	/**
+	* Get the origin of the Dataset if it's a clone.
+	*
+	* @return string The name of the origin if it exists. Otherwise an empty string.
+	* @access public
+	*/
+	public function getOrigin() {
+		if ($this->isClone()) {
+			$origin = $this->getProperty("origin");
+			return $origin['value'];
+		} else {
+			return "";
+		}
+	}
+
+	/**
+	* Promotes the Dataset if it's a clone.
+	*
+	* @return void
+	* @access public
+	*/
+	public function promote() {
+		if ($this->isClone()) {
+			$cmd = "zfs promote " . $this->name . " 2>&1";
+			$this->exec($cmd,$out,$res);
+		}
+	}
+
 	/**
 	 * Helper function to execute a command and throw an exception on error
 	 * (requires stderr redirected to stdout for proper exception message).