X-Git-Url: http://git.datanom.net/omvzfs.git/blobdiff_plain/eb034e478f3c2d700f8ee87bf67dc79159b703cd..c03e412f97676566404534e126c000585743e5aa:/src/Dataset.php diff --git a/src/Dataset.php b/src/Dataset.php index 025126a..2ba1bed 100644 --- a/src/Dataset.php +++ b/src/Dataset.php @@ -27,12 +27,12 @@ class OMVModuleZFSDataset { private $mountPoint; /** - * List of features assigned to the Dataset + * Array with properties assigned to the Dataset * - * @var array $features + * @var array $properties * @access private */ - private $features; + private $properties; // Associations // Operations @@ -41,36 +41,20 @@ class OMVModuleZFSDataset { * Constructor * * @param string $name Name of the new Dataset - * @param array $features An array of features (strings) in the form = to set when creating the Dataset + * @param array $properties An associative array with properties to set when creating the Dataset * @throws OMVModuleZFSException * */ - public function __construct($name, array $features = null) { - $cmd = "zfs create "; - if (isset($features)) { - foreach ($features as $feature) { - $cmd .= "-o " . $feature . " "; - } - } - $cmd .= $name . " 2>&1"; + public function __construct($name, array $properties = null) { + $cmd = "zfs create -p " . $name . " 2>&1"; OMVUtil::exec($cmd,$out,$res); - if ($res == 1) { + if ($res) { throw new OMVModuleZFSException(implode("\n", $out)); } - unset($res); $this->name = $name; - if (isset($features)) { - $this->features = $features; - foreach ($features as $feature) { - if (preg_match('/^mountpoint\=(.*)$/', $feature, $res)) { - $this->mountPoint = $res[1]; - continue; - } - } - } else { - $this->features = array(); - $this->mountPoint = "/" . $name; - } + $this->updateAllProperties(); + $this->setProperties($properties); + $this->mountPoint = $this->properties["mountpoint"][0]; } /** @@ -94,57 +78,132 @@ class OMVModuleZFSDataset { } /** - * Get an array of features associated with the Dataset + * Get a single property value associated with the Dataset * - * @return array $features + * @param string $property Name of the property to fetch + * @return array The returned array key 0=property value and key 1=property source. * @access public */ - public function getFeatures() { - return $this->features; + public function getProperty($property) { + return $this->properties["$property"]; + } + + /** + * Get an associative array of all properties associated with the Dataset. + * + * @return array $properties Each entry is an array where key 0=property value and key + * 1=property source. + * + * @access public + */ + public function getProperties() { + return $this->properties; } /** * Sets a number of Dataset properties. If a property is already set it will be updated with the new value. * - * @param array $features An array of strings in format = + * @param array $properties An associative array with properties to set * @return void * @access public */ - public function setFeatures($features) { - foreach ($features as $newfeature) { - $cmd = "zfs set " . $newfeature . " " . $this->name; + public function setProperties($properties) { + foreach ($properties as $newpropertyk => $newpropertyv) { + $cmd = "zfs set " . $newpropertyk . "=" . $newpropertyv . " " . $this->name; OMVUtil::exec($cmd,$out,$res); - if ($res == 1) { + if ($res) { throw new OMVModuleZFSException(implode("\n", $out)); } - $tmp = explode("=", $newfeature); - $newfeaturek = $tmp[0]; - $found = false; - for ($i=0; $ifeatures); $i++) { - $tmp = explode("=", $this->features[$i]); - $oldfeaturek = $tmp[0]; - if (strcmp($newfeaturek, $oldfeaturek) == 0) { - $this->features[$i] = $newfeature; - $found = true; - continue; - } - } - if (!$found) { - array_push($this->features, $newfeature); - } + $this->updateProperty($newpropertyk); + } + } + + /** + * Get all Dataset properties from commandline and update object properties attribute + * + * @return void + * @throws OMVModuleZFSException + * @access private + */ + private function updateAllProperties() { + $cmd = "zfs get -H all " . $this->name; + OMVUtil::exec($cmd,$out,$res); + if ($res) { + throw new OMVModuleZFSException(implode("\n", $out)); + } + unset($this->properties); + foreach ($out as $line) { + $tmpary = preg_split('/\t+/', $line); + $this->properties["$tmpary[1]"] = array($tmpary[2], $tmpary[3]); + } + } + + /** + * Get single Datset property from commandline and update object property attribute + * + * @param string $property Name of the property to update + * @return void + * @throws OMVModuleZFSException + * @access private + */ + private function updateProperty($property) { + $cmd = "zfs get -H " . $property . " " . $this->name; + OMVUtil::exec($cmd,$out,$res); + if ($res) { + throw new OMVModuleZFSException(implode("\n", $out)); } + $tmpary = preg_split('/\t+/', $out[0]); + $this->properties["$tmpary[1]"] = array($tmpary[2], $tmpary[3]); } /** * Destroy the Dataset. * + * @return void + * @throws OMVModuleZFSException + * @access public */ public function destroy() { $cmd = "zfs destroy " . $this->name; OMVUtil::exec($cmd,$out,$res); - if ($res == 1) { + if ($res) { + throw new OMVModuleZFSException(implode("\n", $out)); + } + } + + /** + * Renames a Dataset + * + * @param string $newname New name of the Dataset + * @return void + * @throws OMVModuleZFSException + * @access public + */ + public function rename($newname) { + $cmd = "zfs rename -p " . $this->name . " " . $newname . " 2>&1"; + OMVUtil::exec($cmd,$out,$res); + if ($res) { + throw new OMVModuleZFSException(implode("\n", $out)); + } + $this->name = $newname; + } + + /** + * Clears a previously set proporty and specifies that it should be + * inherited from it's parent. + * + * @param string $property Name of the property to inherit. + * @return void + * @throws OMVModuleZFSException + * @access public + */ + public function inherit($property) { + $cmd = "zfs inherit " . $property . " " . $this->name . " 2>&1"; + OMVUtil::exec($cmd,$out,$res); + if ($res) { throw new OMVModuleZFSException(implode("\n", $out)); } + $this->updateProperty($property); } }