Fixed some commands in Zvol class.

[omvzfs.git] / src / Zvol.php

diff --git a/src/Zvol.php b/src/Zvol.php
index 82569d433531965ce6f6b377c0c15e5cf30c8362..47701dc48ce5d2364a6874aa51700c52a0712d31 100644 (file)
--- a/src/Zvol.php
+++ b/src/Zvol.php
@@ -23,7 +23,7 @@ class OMVModuleZFSZvol {
        /**
         * Size of Zvol
         *
-        * @var int $size
+        * @var string $size
         * @access private
         */
        private $size;
@@ -50,7 +50,7 @@ class OMVModuleZFSZvol {
        public function __construct($name) {
                $this->name = $name;
                $qname = preg_quote($name, '/');
-               $cmd = "zfs list -H -t volume";
+               $cmd = "zfs list -H -t volume 2>&1";
                $this->exec($cmd, $out, $res);
                foreach ($out as $line) {
                        if (preg_match('/^' . $qname . '\t.*$/', $line)) {
@@ -95,24 +95,28 @@ class OMVModuleZFSZvol {
        }
 
        /**
-        * XXX
+        * Get the total size of the Zvol
         *
-        * @return int XXX
+        * @return string $size
         * @access public
         */
        public function getSize() {
-               trigger_error('Not Implemented!', E_USER_WARNING);
+               return $this->size;
        }
 
        /**
-        * XXX
-        *
-        * @param   $list<Feature> XXX
-        * @return void XXX
+        * Sets a number of Zvol properties. If a property is already set it will be updated with the new value.
+        * 
+        * @param  array $properties An associative array with properties to set
+        * @return void
         * @access public
         */
        public function setProperties($properties) {
-               trigger_error('Not Implemented!', E_USER_WARNING);
+               foreach ($properties as $newpropertyk => $newpropertyv) {
+                       $cmd = "zfs set " . $newpropertyk . "=" . $newpropertyv . " " . $this->name . " 2>&1";
+                       $this->exec($cmd,$out,$res);
+                       $this->updateProperty($newpropertyk);
+               }
        }
 
        /**
@@ -122,7 +126,7 @@ class OMVModuleZFSZvol {
         * @access private
         */
        private function updateAllProperties() {
-               $cmd = "zfs get -H all " . $this->name;
+               $cmd = "zfs get -H all " . $this->name . " 2>&1";
                $this->exec($cmd,$out,$res);
                unset($this->properties);
                foreach ($out as $line) {
@@ -131,17 +135,32 @@ class OMVModuleZFSZvol {
                }
        }
 
+       /**
+        * Get single Datset property from commandline and update object property attribute
+        * 
+        * @param string $property Name of the property to update
+        * @return void
+        * @access private
+        */
+       private function updateProperty($property) {
+               $cmd = "zfs get -H " . $property . " " . $this->name . " 2>&1";
+               $this->exec($cmd,$out,$res);
+               $tmpary = preg_split('/\t+/', $out[0]);
+               $this->properties["$tmpary[1]"] = array("value" => $tmpary[2], "source" => $tmpary[3]);
+       }
+
        /**
         * Create a Zvol on commandline. Optionally provide a number of properties to set.
         * 
         * @param string $size Size of the Zvol that should be created
-        * @param array $properties Properties to set when creating the dataset.
+        * @param array $properties Properties to set when creatiing the dataset.
+        * @param boolean $sparse Defines if a sparse volume should be created.
         * @return void
         * @access public
         */
-       public function create($size, array $properties = null, bool $sparse = null) {
+       public function create($size, array $properties = null, $sparse = null) {
                $cmd = "zfs create -p ";
-               if (isset($sparse) && $sparse == true) {
+               if ((isset($sparse)) && ($sparse == true)) {
                        $cmd .= "-s ";
                }       
                $cmd .= "-V " . $size . " " . $this->name . " 2>&1";
@@ -151,6 +170,44 @@ class OMVModuleZFSZvol {
                $this->size = $this->properties["volsize"]["value"];
        }
 
+       /**
+        * Destroy the Zvol.
+        * 
+        * @return void
+        * @access public
+        */
+       public function destroy() {
+               $cmd = "zfs destroy " . $this->name . " 2>&1";
+               $this->exec($cmd,$out,$res);
+       }
+
+       /**
+        * Renames a Zvol
+        * 
+        * @param string $newname New name of the Dataset
+        * @return void
+        * @access public
+        */
+       public function rename($newname) {
+               $cmd = "zfs rename -p " . $this->name . " " . $newname . " 2>&1";
+               $this->exec($cmd,$out,$res);
+               $this->name = $newname;
+       }
+
+       /**
+        * Clears a previously set proporty and specifies that it should be
+        * inherited from it's parent.
+        * 
+        * @param string $property Name of the property to inherit.
+        * @return void
+        * @access public
+        */
+       public function inherit($property) {
+               $cmd = "zfs inherit " . $property . " " . $this->name . " 2>&1";
+               $this->exec($cmd,$out,$res);
+               $this->updateProperty($property);
+       }
+
        /**
         * Helper function to execute a command and throw an exception on error
         * (requires stderr redirected to stdout for proper exception message).