Fix bug in session handler

[qtadmin.git] / lib / utils.inc.php
diff --git a/lib/utils.inc.php b/lib/utils.inc.php

index 8aa38e083054ae3d3a2e6d6e733d483d5f2b8d90..a792bd5214b75ed5415497f7ad9de997927e3fea 100644 (file)
--- a/lib/utils.inc.php
+++ b/lib/utils.inc.php
@@ -9,6 +9,7 @@ class Utils {
      private $user;
      private $is_admin;
      private $loginStatus;
+    private $timeout;
      private $header = '<!DOCTYPE html>
  <html>
  <head>
@@ -62,20 +63,33 @@ class Utils {
          global $CFG;
  
          if (isset($CFG->session_timeout)) {
-            $timeout = $CFG->session_timeout * 60;
+            $this->timeout = $CFG->session_timeout * 60;
          } else {
-            $timeout = 20 * 60;
+            $this->timeout = 20 * 60;
          }
  
-        if (ini_get('session.gc_maxlifetime') != $timeout)
-            ini_set('session.gc_maxlifetime', $timeout);
-        if (ini_get('session.cookie_lifetime') != $timeout)
-            ini_set('session.cookie_lifetime', $timeout);
+        if (ini_get('session.gc_maxlifetime') != $this->timeout)
+            ini_set('session.gc_maxlifetime', $this->timeout);
+        if (ini_get('session.cookie_lifetime') != $this->timeout)
+            ini_set('session.cookie_lifetime', $this->timeout);
  
          session_start();
  
+        //echo ini_get('session.gc_maxlifetime').':'.ini_get('session.cookie_lifetime');
+    }
+
+    public static function getInstance() {
+        global $CFG;
+
+        if (!is_object(self::$_instance)) {
+            self::$_instance = new Utils();
+        }
+
          $time = $_SERVER['REQUEST_TIME'];
-        if (isset($_SESSION['LAST_ACTIVITY']) && ($time - $_SESSION['LAST_ACTIVITY']) >= $timeout) {
+        if (isset($_SESSION['LAST_ACTIVITY']) &&
+                ($time - $_SESSION['LAST_ACTIVITY']) >= self::$_instance->timeout) {
+            echo 'R_TIME: '.date('c', $time).' L_ACT: '.date('c', $_SESSION['LAST_ACTIVITY']);
+            exit;
              session_unset();
              session_destroy();
              self::$_instance->user = null;
@@ -83,12 +97,6 @@ class Utils {
          } else {
              $_SESSION['LAST_ACTIVITY'] = $time;
          }
-    }
-
-    public static function getInstance() {
-        if (!is_object(self::$_instance)) {
-            self::$_instance = new Utils();
-        }
  
          return self::$_instance;
      }
@@ -170,6 +178,7 @@ class Utils {
          global $CFG;
          $loggedIn = false;
  
+        echo '$this->user: '.$this->user.' $_SESSION['user']: '.$_SESSION['user'];
          if ($this->user) {
              $loggedIn = true;
          } else if (isset($_SESSION['user'])) {
@@ -184,6 +193,10 @@ class Utils {
              }
          }
  
+        if ($loggedIn == false {
+            echo 'R_TIME: '.date('c', $_SERVER['REQUEST_TIME']).' L_ACT: '.date('c', $_SESSION['LAST_ACTIVITY']);
+            exit;
+        }
          return $loggedIn;
      }