Enhance security

[qtadmin.git] / message_view.php

diff --git a/message_view.php b/message_view.php
index 751b65b009cf55ac153fe9dce5917319eb53569a..aa276d82f02c1e93342017b94348922c42788345 100644 (file)
--- a/message_view.php
+++ b/message_view.php
@@ -5,18 +5,23 @@
     require_once $CFG->root . 'lib/db_factory.php';
     require_once $CFG->root . 'lib/utils.inc.php';
 
     require_once $CFG->root . 'lib/db_factory.php';
     require_once $CFG->root . 'lib/utils.inc.php';
 

-    $util = Utils::getInstance();
+    $util = new Utils;

     $loggedIn = $util->isLoggedIn();
     if ($loggedIn && isset($_GET['id'])) {
         $id = $_GET['id'];
         $id = urldecode($id);
 
     $loggedIn = $util->isLoggedIn();
     if ($loggedIn && isset($_GET['id'])) {
         $id = $_GET['id'];
         $id = urldecode($id);
 

+        $mail = unserialize($_SESSION['mailInfo'][$id]);
+
+        if (! is_object($mail) || false == $util->authorized($mail->recipient)) {
+            header('Location: index.php');
+            exit;
+        }
+

         $util->setHeading("Message ID : $id");
         echo $util->getHeader();
         echo $util->getHeading();
 
         $util->setHeading("Message ID : $id");
         echo $util->getHeader();
         echo $util->getHeading();
 

-        $mail = unserialize($_SESSION['mailInfo'][$id]);
-

         $row = $DB->getMail($id);
         $string = $row->mail_text;
         $sa_tests = null;
         $row = $DB->getMail($id);
         $string = $row->mail_text;
         $sa_tests = null;


@@ -35,7 +40,7 @@
               onclick="javascript: history.back();"/></td>';
         echo '</tr></table>';
 
               onclick="javascript: history.back();"/></td>';
         echo '</tr></table>';
 

-        echo '<table><tr>';
+        echo '<table>';

         $from = $headers['from'];
         $from = str_replace("<", "&lt;", $from);
         $from = str_replace(">", "&gt;", $from);
         $from = $headers['from'];
         $from = str_replace("<", "&lt;", $from);
         $from = str_replace(">", "&gt;", $from);